deniskuzZ commented on code in PR #5780:
URL: https://github.com/apache/hive/pull/5780#discussion_r2079656878
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1299,7 +1297,9 @@ private void create_database_core(RawStore ms, final
Database db)
success = ms.commitTransaction();
} finally {
if (!success) {
- ms.rollbackTransaction();
+ if (openTransaction) {
Review Comment:
why are you checking for an `openTransaction` flag here? I don't see the
same check in other places.
````
if (isActiveTransaction() && transactionStatus != TXN_STATUS.ROLLBACK) {
currentTransaction.rollback();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
