saihemanth-cloudera commented on code in PR #5804:
URL: https://github.com/apache/hive/pull/5804#discussion_r2085300600
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java:
##########
@@ -29,23 +30,33 @@
* A wrapper around a list of columns.
*/
public class MColumnDescriptor {
- private List<MFieldSchema> cols;
+ private List<MColumn> columns;
+ private long id;
public MColumnDescriptor() {}
- /**
- *
- * @param cols
- */
public MColumnDescriptor(List<MFieldSchema> cols) {
- this.cols = cols;
+ columns = new ArrayList<>(cols.size());
+ for (MFieldSchema schema : cols) {
+ columns.add(new MColumn(schema.getName(), schema.getType(),
schema.getComment()));
+ }
+ }
+
+ public List<MColumn> getColumns() {
+ return columns;
}
public List<MFieldSchema> getCols() {
- return cols;
+ List<MFieldSchema> schemas = new ArrayList<>();
+ if (getColumns() != null) {
Review Comment:
JDK17 doesn't understand MfieldSchema because of the CLOB column in the join
statement. So now need two representations 1) MfieldSchema in the application
layer 2) Mcolumn in the JDO layer for conversion to/from the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
