deniskuzZ commented on code in PR #5804:
URL: https://github.com/apache/hive/pull/5804#discussion_r2085514269
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java:
##########
@@ -29,23 +30,33 @@
* A wrapper around a list of columns.
*/
public class MColumnDescriptor {
- private List<MFieldSchema> cols;
+ private List<MColumn> columns;
+ private long id;
public MColumnDescriptor() {}
- /**
- *
- * @param cols
- */
public MColumnDescriptor(List<MFieldSchema> cols) {
- this.cols = cols;
+ columns = new ArrayList<>(cols.size());
+ for (MFieldSchema schema : cols) {
+ columns.add(new MColumn(schema.getName(), schema.getType(),
schema.getComment()));
+ }
+ }
+
+ public List<MColumn> getColumns() {
+ return columns;
}
public List<MFieldSchema> getCols() {
- return cols;
+ List<MFieldSchema> schemas = new ArrayList<>();
+ if (getColumns() != null) {
Review Comment:
i understand that, but why do you need to reconstruct the `getCols() `
representation
{code}
private List<MColumn> fields;
private long id;
private List<MFieldSchema> cols;
public MColumnDescriptor(List<MFieldSchema> cols) {
this.cols = cols;
this.fields = cols.stream().map(schema ->
new MColumn(schema.getName(), schema.getType(), schema.getComment()))
.collect(Collectors.toList());
}
public List<MColumn> getFields() {
return fields;
}
public List<MFieldSchema> getCols() {
return cols
}
{code}
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java:
##########
@@ -29,23 +30,33 @@
* A wrapper around a list of columns.
*/
public class MColumnDescriptor {
- private List<MFieldSchema> cols;
+ private List<MColumn> columns;
+ private long id;
public MColumnDescriptor() {}
- /**
- *
- * @param cols
- */
public MColumnDescriptor(List<MFieldSchema> cols) {
- this.cols = cols;
+ columns = new ArrayList<>(cols.size());
+ for (MFieldSchema schema : cols) {
+ columns.add(new MColumn(schema.getName(), schema.getType(),
schema.getComment()));
+ }
+ }
+
+ public List<MColumn> getColumns() {
+ return columns;
}
public List<MFieldSchema> getCols() {
- return cols;
+ List<MFieldSchema> schemas = new ArrayList<>();
+ if (getColumns() != null) {
Review Comment:
i understand that, but why do you need to reconstruct the `getCols() `
representation
````
private List<MColumn> fields;
private long id;
private List<MFieldSchema> cols;
public MColumnDescriptor(List<MFieldSchema> cols) {
this.cols = cols;
this.fields = cols.stream().map(schema ->
new MColumn(schema.getName(), schema.getType(), schema.getComment()))
.collect(Collectors.toList());
}
public List<MColumn> getFields() {
return fields;
}
public List<MFieldSchema> getCols() {
return cols
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
