Aggarwal-Raghav commented on code in PR #5827:
URL: https://github.com/apache/hive/pull/5827#discussion_r2109448198


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlInsertPart.java:
##########
@@ -754,7 +754,7 @@ public void addPartitions(List<MPartition> parts, 
List<List<MPartitionPrivilege>
       serdeIdToSerDeInfo.put(serDeId, sd.getSerDeInfo());
 
       Long cdId;
-      DatastoreId storeId = (DatastoreId) pm.getObjectId(sd.getCD());
+      LongIdentity storeId = (LongIdentity) pm.getObjectId(sd.getCD());

Review Comment:
   Yes, this is a regression. I checked with and without 
[HIVE-28909](https://issues.apache.org/jira/browse/HIVE-28909) in master branch 
with JDK8, datanucleus 5.x as well. Attaching screenshots for reference:
   **Without HIVE-28909:**
   <img width="703" alt="DataNucleus_5 x_without_28909" 
src="https://github.com/user-attachments/assets/ff742f7f-cd9d-4a5b-94da-0f4b73a47a75";
 />
   
   **With HIVE-28909**
   <img width="817" alt="DataNucleus_5 x_with_28909" 
src="https://github.com/user-attachments/assets/ad50679f-87b6-4a9c-be2e-5040201d7f3b";
 />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to