ayushtkn commented on code in PR #5827:
URL: https://github.com/apache/hive/pull/5827#discussion_r2109732526
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlInsertPart.java:
##########
@@ -754,7 +754,7 @@ public void addPartitions(List<MPartition> parts,
List<List<MPartitionPrivilege>
serdeIdToSerDeInfo.put(serDeId, sd.getSerDeInfo());
Long cdId;
- DatastoreId storeId = (DatastoreId) pm.getObjectId(sd.getCD());
+ LongIdentity storeId = (LongIdentity) pm.getObjectId(sd.getCD());
Review Comment:
Most of the hive tests just check the query output, not like what route it
took to complete.
the case with DirectSql is like if it fails, Hive automatically fallbacks to
the JDO layer, without failing the query, so unless the response via JDO is
different as compared to DirectSql, which it shouldn’t be unless there is bug.
I belive the tests won’t fail, just a warning log in the test log, which we
don’t check :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
