okumin commented on code in PR #5837: URL: https://github.com/apache/hive/pull/5837#discussion_r2120985814
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDayOfWeekString.java: ########## @@ -36,8 +36,7 @@ public final class VectorUDFDayOfWeekString extends VectorUDFTimestampFieldStrin private static final long serialVersionUID = 1L; private transient final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd"); - private transient final Calendar calendar = Calendar.getInstance( - TimeZone.getTimeZone("UTC")); + private transient final Calendar calendar = Calendar.getInstance(); public VectorUDFDayOfWeekString(int colNum, int outputColumnNum) { Review Comment: Do you think we can use the same logic as the non-vectorized version? https://github.com/apache/hive/blob/de994e5c556930d1761601a61d6941c69fa9e153/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfWeek.java#L68-L72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org