tanishq-chugh commented on code in PR #5837:
URL: https://github.com/apache/hive/pull/5837#discussion_r2121154770
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDayOfWeekString.java:
##########
@@ -36,8 +36,7 @@ public final class VectorUDFDayOfWeekString extends
VectorUDFTimestampFieldStrin
private static final long serialVersionUID = 1L;
private transient final SimpleDateFormat format = new
SimpleDateFormat("yyyy-MM-dd");
- private transient final Calendar calendar = Calendar.getInstance(
- TimeZone.getTimeZone("UTC"));
+ private transient final Calendar calendar = Calendar.getInstance();
public VectorUDFDayOfWeekString(int colNum, int outputColumnNum) {
Review Comment:
Yes, that would be much better. It would be more consistent and we'll be
using Hive's DateParser instead as well.
Thanks for catching this !
Have made the change in
[49f08e0](https://github.com/apache/hive/pull/5837/commits/49f08e038b51d4706d7acabb16f16f352265fe44)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
