Paramvir109 commented on code in PR #5845:
URL: https://github.com/apache/hive/pull/5845#discussion_r2134651600
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -105,6 +110,23 @@ public void init(ExecMapperContext context, MapredContext
mrContext,
this.htLoadCounter =
tezContext.getTezProcessorContext().getCounters().findCounter(counterGroup,
counterName);
}
+ @VisibleForTesting
+ protected void initHTLoadingServiceForTest(Configuration conf, long
estKeyCount, ExecutorService loadExecService) {
Review Comment:
Hey @deniskuzZ, The method which I need to test - `submitQueueDrainThreads`
is a private method hence I'm making a protected testing method which will
actually call the private method. And `initHTLoadingService` method which is
responsible for initialising all the class members(private) required for this
test also has a private access in the class. I won't be able to mock private
class members. I can use reflection to set the private class members but it
won't be a good idea I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
