deniskuzZ commented on code in PR #5845:
URL: https://github.com/apache/hive/pull/5845#discussion_r2135375514
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -105,6 +110,23 @@ public void init(ExecMapperContext context, MapredContext
mrContext,
this.htLoadCounter =
tezContext.getTezProcessorContext().getCounters().findCounter(counterGroup,
counterName);
}
+ @VisibleForTesting
+ protected void initHTLoadingServiceForTest(Configuration conf, long
estKeyCount, ExecutorService loadExecService) {
Review Comment:
just make the method package-private and use it a test
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -105,6 +110,23 @@ public void init(ExecMapperContext context, MapredContext
mrContext,
this.htLoadCounter =
tezContext.getTezProcessorContext().getCounters().findCounter(counterGroup,
counterName);
}
+ @VisibleForTesting
+ protected void initHTLoadingServiceForTest(Configuration conf, long
estKeyCount, ExecutorService loadExecService) {
Review Comment:
please make the method package-private and use it in a test. Please do not
add any test-specific functions in the production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
