deniskuzZ commented on code in PR #5651:
URL: https://github.com/apache/hive/pull/5651#discussion_r2135690524


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map<String, 
ExprNodeDesc> targetCol2
     return newOutputRR;
   }
 
+  List<ExprNodeDesc> transformColList(List<ExprNodeDesc> colList) {
+    List<ExprNodeDesc> trfColList = new ArrayList<>();

Review Comment:
   @KiranVelumuri,  why do you need to construct list if you are only 
interested in size?
   also could you explain (add java doc for the method) what kind of 
transformation is happening here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to