KiranVelumuri commented on code in PR #5651:
URL: https://github.com/apache/hive/pull/5651#discussion_r2137089553
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map<String,
ExprNodeDesc> targetCol2
return newOutputRR;
}
+ List<ExprNodeDesc> transformColList(List<ExprNodeDesc> colList) {
+ List<ExprNodeDesc> trfColList = new ArrayList<>();
Review Comment:
In case of CBO=false, the error mentioned in the Jira is thrown from
[here](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L5089)
inside handleInsertStatementSpec method and the operation in the method is not
done(but has to be done). This is due to columns present as complex datatype
and this is used for comparison.
Instead, what I did here is to decompose(or transform) the complex datatype
into its constituent entities and perform operations from [this code
block](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L4979-L4995).
This is what would happen if CBO were true, and hence we need to construct the
list.
I will add the java doc for the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
