deniskuzZ commented on code in PR #5887:
URL: https://github.com/apache/hive/pull/5887#discussion_r2160244437
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -104,6 +83,11 @@ protected Catalog createCatalog() {
if (configExtWarehouse != null) {
properties.put("external-warehouse", configExtWarehouse);
}
+ // For the testing purpose. HiveCatalog caches a metastore client in a
static field. As our tests can spin up
+ // multiple HMS instances, we need a unique cache key.
+ final String servletIdKey = "metastore.iceberg.catalog.servlet.id";
Review Comment:
please move it to constants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
