deniskuzZ commented on code in PR #5887:
URL: https://github.com/apache/hive/pull/5887#discussion_r2160246273
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -130,12 +114,7 @@ protected HttpServlet createServlet(Catalog catalog) {
*/
protected HttpServlet createServlet() throws IOException {
if (port >= 0 && path != null && !path.isEmpty()) {
- Catalog actualCatalog = catalog;
- if (actualCatalog == null) {
- actualCatalog = catalog = createCatalog();
- }
- setLastCatalog(actualCatalog);
- return createServlet(actualCatalog);
+ return createServlet(createCatalog());
Review Comment:
could you please check the `protected` modifiers if we need them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
