ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2179225056
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -114,68 +50,11 @@
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
-public class HiveMetaStoreClient implements IMetaStoreClient, AutoCloseable {
-
- private final String CLASS_NAME = HiveMetaStoreClient.class.getName();
-
+public class HiveMetaStoreClient extends BaseMetaStoreClientProxy implements
IMetaStoreClient, AutoCloseable {
Review Comment:
From my understanding, `HiveMetaStoreClient` is the public-facing
implementation of `IMetaStoreClient`, incorporating both the Hook and Thrift
layers. For example, many tests and even Spark directly instantiate
`HiveMetaStoreClient` to connect to HMS.
If we rename `ThriftHiveMetaStoreClient` to `HiveMetaStoreClient` without
the Hook feature, we would then need to wrap it with HookProxy wherever it is
required. Given that there are around 222 (possibly inaccurate) instantiation
points in the test code alone, I think it is more practical to keep the current
structure. If it is possible to rename/refactor `ThriftHiveMetaStoreClient` to
`HiveMetaStoreClient` with Hook feature included, I am not opposed to the
renaming, although I am not sure whether that is compatible with the Iceberg
hook implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
