dengzhhu653 commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2179342783
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -6006,11 +6009,20 @@ public HiveMetaHook getHook(
}
};
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
+ IMetaStoreClient clientWithLocalCache = new
HiveMetaStoreClientWithLocalCache(conf, thriftClient);
+ IMetaStoreClient sessionLevelClient = new SessionHiveMetaStoreClient(conf,
clientWithLocalCache);
+ IMetaStoreClient clientWithHook = new
HookEnabledMetaStoreClientProxy(conf, hookLoader, sessionLevelClient);
Review Comment:
Looks like we don't call the preCreateTable hook in
https://github.com/apache/hive/blob/46cd5bfa148b9e46e49a8cd566c2ec65628b0c1d/ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java#L699
while creating the temporary table.
I guess we might need to move this check into session client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
