deniskuzZ commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-3039769266
> @deniskuzZ, I have updated the PR according to your renaming requests below. Regarding `SynchronizedMetaStoreClient`, since there are now two classes with that name in `Hive.java`, I decided to use FQN for the class formerly called as `SynchronizedMetaStoreClientProxy`, as it comes from a different package. > > I hope these changes don't break anything. I'll check and fix anything I might have missed in the morning. > > > * BaseMetaStoreClientProxy -> MetaStoreClientProxy > > * HookEnabledMetaStoreClientProxy -> HookEnabledMetaStoreClient > > * SynchronizedMetaStoreClientProxy -> SynchronizedMetaStoreClient @ngsg, how about `[Base]MetaStoreClientProxy` -> `MetaStoreClientWrapper`? i think that is the best fit here. Note, I can rename in the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
