ngsg commented on PR #5771:
URL: https://github.com/apache/hive/pull/5771#issuecomment-3040860697
> @ngsg, how about `[Base]MetaStoreClientProxy` -> `MetaStoreClientWrapper`?
i think that is the best fit here. Note, I can rename in the next PR.
I'll do that, as there remains minor work.
---
> also we can kill the hive-exec `SynchronizedMetaStoreClient` and replace
with `metastore.client.SynchronizedMetaStoreClient`
>
> ```
> private IMetaStoreClient syncMetaStoreClient;
> ....
> @LimitedPrivate(value = {"Hive"})
> public synchronized IMetaStoreClient getSynchronizedMSC() throws
MetaException {
> if (syncMetaStoreClient == null) {
> syncMetaStoreClient = SynchronizedMetaStoreClient.newClient(getConf(),
getMSC(true, false));
> }
> return syncMetaStoreClient;
> }
> ```
I think we can even drop `getSynchronizedMSC`, since there is no
unsynchronized MetaStoreClient; now all MetaStoreClients are wrapped by
`metastore.client.SynchronizedMetaStoreClient`. I'm not sure why we introduced
two redundant synchronization mechanism in
`HiveMetaStoreClient.newSynchronizedClient` (HIVE-1899) and hive-exec
`SynchronizedMetaStoreClient` (HIVE-14204), but I believe that we can unify
them into a single class. I'm OK with going with any weaker changes as well,
but I would like to hear your thoughts on the proposed commit.
---
Regarding the failed test cases, I couldn't reproduce them in my local
environment, and I believe they're likely unrelated to the changes.
```
mvn test -pl itests/qtest-iceberg,ql -Pitests -Dtest.groups=
-Dtest=TestReplicationMetricCollector#testSuccessIncrLoadMetrics,TestIcebergLlapLocalCompactorCliDriver
-Dqfile=iceberg_major_compaction_partitioned.q
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
