mdayakar commented on code in PR #5978:
URL: https://github.com/apache/hive/pull/5978#discussion_r2218491934
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveUnionSimpleSelectsToInlineTableRule.java:
##########
@@ -218,6 +218,9 @@ private boolean isInlineTableOperand(RelNode input) {
if (input.getInputs().size() == 0) {
return true;
}
+ if (!(((RexCall)((HiveTableFunctionScan)
input).getCall()).getOperands().get(0) instanceof RexCall)) {
+ return false;
+ }
Review Comment:
For VALUES also finally it converts to inline UDTF when it comes to this
rule and they will be combined. I thought for VALUES it will be converted
differently so I said we can not use "inline" string comparison but we don't
know exactly the other scenarios so I feel current checks might be enough to
prevent ClassCastException and no impact to the existing behaviour..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
