zabetak commented on code in PR #5978:
URL: https://github.com/apache/hive/pull/5978#discussion_r2218683864
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveUnionSimpleSelectsToInlineTableRule.java:
##########
@@ -218,6 +218,9 @@ private boolean isInlineTableOperand(RelNode input) {
if (input.getInputs().size() == 0) {
return true;
}
+ if (!(((RexCall)((HiveTableFunctionScan)
input).getCall()).getOperands().get(0) instanceof RexCall)) {
+ return false;
+ }
Review Comment:
They are enough to prevent the ClassCastException observed here but not
sufficient to cover problems with other combinations UDTF as pointed out in
another comment. Anyways, this is out-of-scope of this PR so marking this
discussion as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
