deniskuzZ commented on code in PR #5955:
URL: https://github.com/apache/hive/pull/5955#discussion_r2227823924
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1728,6 +1728,10 @@ public enum ConfVars {
" and password. Any other value is ignored right now but
may be used later."
+ "If JWT- Supported only in HTTP transport mode. If set, HMS
Client will pick the value of JWT from "
+ "environment variable HMS_JWT and set it in Authorization
header in http request"),
+ METASTORE_CLIENT_CLASS("metastore.client.class",
+ "hive.metastore.client.class",
+ "org.apache.hadoop.hive.metastore.client.ThriftHiveMetaStoreClient",
+ "The name of MetaStoreClient class that implements the
IMetaStoreClient interface."),
Review Comment:
I don't think we need multiple client impl for the same catalog (aka
Snowflake, Glue, HMS, Rest, etc)
Instead, I’d suggest using a simple comma-separated list. Later, that would
be persisted to the backend database during the Catalog registration
(HIVE-26227)
````
METASTORE_CLIENT_IMPL("metastore.client.impl", catalog:client_classname)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
