ngsg commented on code in PR #5955:
URL: https://github.com/apache/hive/pull/5955#discussion_r2230236924
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1728,6 +1728,10 @@ public enum ConfVars {
" and password. Any other value is ignored right now but
may be used later."
+ "If JWT- Supported only in HTTP transport mode. If set, HMS
Client will pick the value of JWT from "
+ "environment variable HMS_JWT and set it in Authorization
header in http request"),
+ METASTORE_CLIENT_CLASS("metastore.client.class",
+ "hive.metastore.client.class",
+ "org.apache.hadoop.hive.metastore.client.ThriftHiveMetaStoreClient",
+ "The name of MetaStoreClient class that implements the
IMetaStoreClient interface."),
Review Comment:
> @ngsg maybe `METASTORE_CLIENT_IMPL`, similar to `RAW_STORE_IMPL`?
I changed METASTORE_CLINT_CLASS to METASTORE_CLIENT_IMPL and
metastore.client.class to metastore.client.impl.
---
> how about a new property to configure those mappings? e.g,
`metastore.client.meta.class.mappings`=`catalog:client_classname,catalog.db(or
db_pattern):client_classname,catalog.db.table:client_classname`
Regarding the mapping, if there were no ThriftHiveMetaStoreClient-related
logic in HiveMetaStoreClient, I think I could implement a mapping from a
catalog to the actual client. However, due to that logic, I don't currently
have a clear design to support it. Let me think more about a better design and
share my thoughts once I’ve summarized them.
---
Another thought I had is that if we eventually implement HIVE-28879, we may
not need this configuration key to specify either a single class or a mapping,
since the relevant information would be stored in the MetaStore backend
database. Given that we likely have enough time before the next release, I'm
unsure about the feasibility of introducing a temporary configuration key that
won't appear in any release. What do you think about keeping this patch as a
fallback option in case HIVE-28879 isn't ready in time for the next release,
and proceeding directly with HIVE-28879 for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
