wecharyu opened a new pull request, #6006: URL: https://github.com/apache/hive/pull/6006
### What changes were proposed in this pull request? We can refactor `MetaStoreFS.deleteDir()` and `FileUtils.moveToTrash()` to get a cleaner code: 1. remove unused parameter `recursive` 2. remove `purge` parameter in `moveToTrash` because we should call `moveToTrash` only when `purge` is false 3. move `fs.delete()` calls from `moveToTrash()` to `deleteDir()` 4. log the root cause when `moveToTrash()` failed ### Why are the changes needed? Refactor code. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Passing existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
