kasakrisz commented on PR #6009: URL: https://github.com/apache/hive/pull/6009#issuecomment-3160129849
@soumyakanti3578 How cases handled when the rows in the window does not fit into one batch? * Case of `first_value respect nulls` is easy because we take the first row in the first batch. * Case of `last_value respect nulls` is more challenging because we need the value from the last batch. However the last row in the window is not always the last row in the batch. I mean it is not `batch.size - 1`. Is this true? * Case of `first_value ignore nulls`. What if all the values are null in the first batch? We need to check the follow up batches. * Case of `last_value ignore nulls`. As you already implemented in this patch iterate back from `batch.size - 1` until we find a non-null value. This is good when we have one batch but it is more challenging when we have follow-up batches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
