kasakrisz commented on PR #6009: URL: https://github.com/apache/hive/pull/6009#issuecomment-3164409020
@soumyakanti3578 Thanks for the detailed explanation. Overall the patch seems to be ok to me. One note for the testing part: IMHO it worth adding test cases for both: * batch size is big enough to load all the records into one batch from the table * or batch size is too small and the windows are loaded into more than one batch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
