zhengchenyu commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2262006594
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##########
@@ -345,9 +353,9 @@ void close() {
try {
if (isAborted()) {
for (ReduceRecordSource rs : sources) {
- if (!rs.close()) {
- setAborted(false); // Preserving the old logic. Hmm...
- break;
+ boolean abort = rs.close();
+ if (!isAborted() && abort) {
Review Comment:
> isAborted() is always true here. i don't understand what are you trying to
accomplish here: set true -> true?
I have a problem with migrating the code from our internal version. I will
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
