deniskuzZ commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2293711032
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##########
@@ -343,12 +351,10 @@ void close() {
}
try {
- if (isAborted()) {
- for (ReduceRecordSource rs : sources) {
- if (!rs.close()) {
- setAborted(false); // Preserving the old logic. Hmm...
- break;
- }
+ for (ReduceRecordSource rs : sources) {
Review Comment:
also in my opinion it's not logical to return true in `rs.close()` when you
need to abort. true usually means success
````
boolean close() throws Exception {
...
return !abort;
}
````
and then
````
boolean abort = isAborted();
for (ReduceRecordSource rs: sources) {
abort |= !rs.close();
}
if (abort) {
setAborted(true);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
