henrib commented on code in PR #5882:
URL: https://github.com/apache/hive/pull/5882#discussion_r2267011081
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCachingCatalog.java:
##########
@@ -63,6 +69,48 @@ public List<Namespace> listNamespaces(Namespace nmspc)
throws NoSuchNamespaceExc
return hiveCatalog.listNamespaces(nmspc);
}
+ @Override
+ public Table loadTable(TableIdentifier identifier) {
+ final Cache<TableIdentifier, Table> cache = this.tableCache;
+ final HiveCatalog catalog = this.hiveCatalog;
+ final TableIdentifier canonicalized = identifier.toLowerCase();
+ Table cachedTable = cache.getIfPresent(canonicalized);
+ if (cachedTable != null) {
+ String location = catalog.getTableLocation(canonicalized);
Review Comment:
> location objects won't ever match !!! one returns metadata file location
and another just the root table location
You are absolutely right, I must missed that during debug, thanks for
catching it. It could have been fixed with a call to:
` private static String getMetadataLocation(final Table table) {
if (table instanceof HasTableOperations tableOps) {
final TableOperations ops = tableOps.operations();
final TableMetadata meta;
if (ops != null && (meta = ops.current()) != null) {
return meta.metadataFileLocation();
}
}
return null;
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
