okumin commented on code in PR #5882:
URL: https://github.com/apache/hive/pull/5882#discussion_r2268716822
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCachingCatalog.java:
##########
@@ -63,6 +69,48 @@ public List<Namespace> listNamespaces(Namespace nmspc)
throws NoSuchNamespaceExc
return hiveCatalog.listNamespaces(nmspc);
}
+ @Override
+ public Table loadTable(TableIdentifier identifier) {
+ final Cache<TableIdentifier, Table> cache = this.tableCache;
+ final HiveCatalog catalog = this.hiveCatalog;
+ final TableIdentifier canonicalized = identifier.toLowerCase();
+ Table cachedTable = cache.getIfPresent(canonicalized);
+ if (cachedTable != null) {
+ String location = catalog.getTableLocation(canonicalized);
Review Comment:
> location objects won't ever match !!!
You're right. My bad. Let's add an addendum patch.
> 1 remark: hive-catalog is a clone of iceberg's hive-metastore. So whenever
we need to apply changes there - we should raise a PR for iceberg as well.
I'm not finding the policy about how to manage cloned files, but it is also
right anyway. I'm wondering if we can push the entire caching feature into
HiveCatalog in apache/iceberg. I can try it in my spare time if no one tries it.
> @okumin, I think similar thing was discussed in
https://lists.apache.org/thread/zb5ldjfxvjz4fjwll1lc9cm8rl015zx2
Thanks for identifying the related discussion. We might want to implement
the finally-decided solution, probably the ETag-based one.
- https://github.com/apache/iceberg/issues/11766
-
https://docs.google.com/document/d/1rnVSP_iv2I47giwfAe-Z3DYhKkKwWCVvCkC9rEvtaLA/edit?tab=t.0#heading=h.5voryi2hj0go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
