deniskuzZ commented on code in PR #6022:
URL: https://github.com/apache/hive/pull/6022#discussion_r2272594504
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCachingCatalog.java:
##########
@@ -63,6 +69,96 @@ public List<Namespace> listNamespaces(Namespace nmspc)
throws NoSuchNamespaceExc
return hiveCatalog.listNamespaces(nmspc);
}
+ protected void cacheInvalidateInc(TableIdentifier tid) {
+ // This method is intentionally left empty. It can be overridden in
subclasses if needed.
Review Comment:
what subclasses, please do not over-engineer
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCachingCatalog.java:
##########
@@ -63,6 +69,96 @@ public List<Namespace> listNamespaces(Namespace nmspc)
throws NoSuchNamespaceExc
return hiveCatalog.listNamespaces(nmspc);
}
+ protected void cacheInvalidateInc(TableIdentifier tid) {
+ // This method is intentionally left empty. It can be overridden in
subclasses if needed.
Review Comment:
what subclasses? please do not over-engineer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
