deniskuzZ commented on code in PR #6002: URL: https://github.com/apache/hive/pull/6002#discussion_r2273541314
########## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/properties/HMSServletTest.java: ########## @@ -92,30 +86,34 @@ protected void stopServer(int port) throws Exception { } } + protected static String getScheme(Configuration conf) { + return MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.USE_SSL) ? "https" : "http"; Review Comment: can we use constants from `org.eclipse.jetty.util.URIUtil`? does it have to be protected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org