deniskuzZ commented on code in PR #6002:
URL: https://github.com/apache/hive/pull/6002#discussion_r2275949577
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/properties/HMSJsonClientSslTest.java:
##########
@@ -92,30 +89,34 @@ protected void stopServer(int port) throws Exception {
}
}
+ protected static String getScheme(Configuration conf) {
+ return MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.USE_SSL) ?
HTTPS : HTTP;
+ }
@Override
- protected PropertyClient createClient(Configuration conf, int sport) throws
Exception {
- String path = MetastoreConf.getVar(conf,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_PATH);
- URL url = new URL("http://hive@localhost:"; + sport + "/" + path + "/" +
NS);
+ protected PropertyClient createClient(Configuration conf, int port) throws
Exception {
+ String servletPath = MetastoreConf.getVar(conf,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_PATH);
Review Comment:
minor: The local variable declaration could be replaced with a `path` field
in several places, including in inherited test classes such as
HMSHttpClientSslTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
