deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279052857
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -324,6 +332,12 @@ public void
rollbackCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTa
@Override
public void commitCreateTable(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
+ String catalogType = MetastoreConf.get(conf,
MetastoreConf.ConfVars.HIVE_ICEBERG_CATALOG_TYPE.getHiveName());
+ if (catalogType != null && !catalogType.isEmpty()) {
+ // If the catalog type is set, we assume that the table has been created
in the delegate.createTable(request) call
Review Comment:
what about other commits like `commitAlterTable`, `commitDropTable`,
`commitInsertTable`? we should probably skip them as well
would be nice to have some generic solution, maybe even create diff hook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
