deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2279118555
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -1097,13 +1116,16 @@ private void
setOrcOnlyFilesParam(org.apache.hadoop.hive.metastore.api.Table hms
}
private boolean isOrcOnlyFiles(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
- return
!"FALSE".equalsIgnoreCase(hmsTable.getParameters().get(ORC_FILES_ONLY)) &&
+ Map<String, String> hmsParameters =
Optional.ofNullable(hmsTable.getParameters()).orElseGet(Maps::newHashMap);
Review Comment:
why not change hmsTable.getParameters() return empty map instead of changes
in multiple places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
