deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2285436069
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -272,12 +264,20 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
/**
* Collect all the catalog specific configuration from the global hive
configuration.
* @param conf a Hadoop configuration
- * @param catalogName name of the catalog
+ * @param catalogName type of the catalog
* @return complete map of catalog properties
*/
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName) {
Map<String, String> catalogProperties = Maps.newHashMap();
- String keyPrefix = InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName;
+
+ String keyPrefix;
+ if (catalogName == null ||
ICEBERG_DEFAULT_CATALOG_NAME.equals(catalogName)) {
Review Comment:
please fix this as discussed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
