difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2285631878
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -441,7 +441,8 @@ public void
appendFiles(org.apache.hadoop.hive.metastore.api.Table table, URI fr
Map<String, String> partitionSpec)
throws SemanticException {
Table icebergTbl = IcebergTableUtil.getTable(conf, table);
- String format =
table.getParameters().get(TableProperties.DEFAULT_FILE_FORMAT);
+ String format =
Optional.ofNullable(table.getParameters()).orElseGet(Maps::newHashMap)
Review Comment:
reverted.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -133,8 +133,8 @@ static Table getTable(Configuration configuration,
org.apache.hadoop.hive.metast
Properties properties = new Properties();
properties.setProperty(Catalogs.NAME,
TableIdentifier.of(hmsTable.getDbName(), hmsTable.getTableName()).toString());
properties.setProperty(Catalogs.LOCATION, hmsTable.getSd().getLocation());
- hmsTable.getParameters().computeIfPresent(InputFormatConfig.CATALOG_NAME,
- (k, v) -> {
+ Optional.ofNullable(hmsTable.getParameters()).orElseGet(Maps::newHashMap)
Review Comment:
reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
