difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2286407779


##########
pom.xml:
##########
@@ -581,6 +583,21 @@
         <artifactId>httpcore</artifactId>
         <version>${httpcomponents.core.version}</version>
       </dependency>
+      <dependency>

Review Comment:
   I think so, because it appears here in dependencyManagement section which 
only defines versions for use anywhere in the project. It allows to not 
hardcode the httpcore in iceberg-catalog. We also said in the next PRs we are 
going to replace httpcomponenent4 with httpcomponenent5 and the definition in 
the project-wide dependency management section will be handy for that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to