difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2286174544


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -321,14 +329,25 @@ private void 
setSortOrder(org.apache.hadoop.hive.metastore.api.Table hmsTable, S
   public void rollbackCreateTable(org.apache.hadoop.hive.metastore.api.Table 
hmsTable) {
     // do nothing
   }
+  
+  private boolean shouldSkipCommit() {

Review Comment:
   Yes, done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to