InvisibleProgrammer commented on code in PR #6040:
URL: https://github.com/apache/hive/pull/6040#discussion_r2297386151
##########
ql/src/test/results/clientpositive/llap/tez_compile_counters.q.out:
##########
@@ -1501,7 +1501,7 @@ Stage-1 HIVE COUNTERS:
RECORDS_OUT_INTERMEDIATE_Map_4: 240
RECORDS_OUT_INTERMEDIATE_Reducer_2: 952
RECORDS_OUT_INTERMEDIATE_Reducer_3: 0
- RECORDS_OUT_OPERATOR_EVENT_30: 1
+ RECORDS_OUT_OPERATOR_EVENT_30: 309
Review Comment:
That change revealed something that looks like a bug in thforward method:
It doesn't calculate the size of the batch at all, it just adds 1 to the
statistics:
```java
protected void forward(Object row, ObjectInspector rowInspector)
throws HiveException {
runTimeNumRows++;
```
I wonder, is it worth fixing in this ticket or a new one? Or it is
intentional?
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java#L875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
