ngsg commented on code in PR #6040:
URL: https://github.com/apache/hive/pull/6040#discussion_r2297480388
##########
ql/src/test/results/clientpositive/llap/tez_compile_counters.q.out:
##########
@@ -1501,7 +1501,7 @@ Stage-1 HIVE COUNTERS:
RECORDS_OUT_INTERMEDIATE_Map_4: 240
RECORDS_OUT_INTERMEDIATE_Reducer_2: 952
RECORDS_OUT_INTERMEDIATE_Reducer_3: 0
- RECORDS_OUT_OPERATOR_EVENT_30: 1
+ RECORDS_OUT_OPERATOR_EVENT_30: 309
Review Comment:
As you pointed out, `vectorForward()` handles batch size correctly, while
`forward()` ignores it. That's why switching to `vectorForward()` changes the
stats from 1 to 309. However, since vectorized operators should use
`vectorForward()`, I believe `forward()` does not need to consider
`VectorizedRowBatch`, and both methods behave as intended. Please let me know
if I misunderstood your point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
