deniskuzZ commented on code in PR #6039:
URL: https://github.com/apache/hive/pull/6039#discussion_r2298304378
##########
standalone-metastore/metastore-client/src/main/java/org/apache/hadoop/hive/metastore/utils/TableFetcher.java:
##########
@@ -110,24 +112,29 @@ public List<TableName> getTableNames() throws Exception {
return candidates;
}
- public List<Table> getTables(int maxBatchSize) throws Exception {
- List<Table> candidates = new ArrayList<>();
-
+ public Iterable<Table> getTables(int maxBatchSize, Set<String> skipDBs,
Set<String> skipTables) throws Exception {
Review Comment:
could we please use next signatures
````
public Iterable<Table> getTables(Set<String> skipDBs, Set<String>
skipTables, int maxBatchSize)
public Iterable<Table> getTables(int maxBatchSize) {
return getTables(null, null, maxBatchSize)
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
