deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2300324729
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##########
@@ -87,6 +88,34 @@ public class Warehouse {
private boolean storageAuthCheck = false;
private ReplChangeManager cm = null;
+ public enum CatalogType {
+ REST("rest", "org.apache.iceberg.hive.client.HiveRESTCatalogClient"),
+ DEFAULT("default",
MetastoreConf.ConfVars.METASTORE_CLIENT_IMPL.getDefaultVal().toString());
+
+ private final String type;
+ private final String clientImplClass;
+
+ CatalogType(String type, String clientImplClass) {
+ this.type = type;
+ this.clientImplClass = clientImplClass;
+ }
+
+ public String getClientImplClass() {
+ return clientImplClass;
+ }
+
+ public static CatalogType getCatalogType(String type) {
Review Comment:
MetaStoreUtils.class
````
public static String getCatalogImpl(Configuration conf) {
String type = getCatalogType(conf);
return (StringUtils.isEmpty(type) ?
CatalogType.DEFAULT : CatalogType.valueOf(type.toUpperCase())
).getClientImplClass();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
