deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2300389293
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -257,7 +258,8 @@ public Class<? extends AbstractSerDe> getSerDeClass() {
public HiveMetaHook getMetaHook() {
// Make sure to always return a new instance here, as HiveIcebergMetaHook
might hold state relevant for the
// operation.
- return new HiveIcebergMetaHook(conf);
+ return StringUtils.isEmpty(MetaStoreUtils.getCatalogType(conf)) ?
Review Comment:
that might not work for Hive managed iceberg catalogs. Do we need 2 type
here: Hive managed and external catalogs?
````
MetaStoreUtils.isExternalCatalog(conf) ?
new BaseHiveIcebergMetaHook(conf) : new HiveIcebergMetaHook(conf);
````
ATM hadoop catalog uses `HiveIcebergMetaHook` as well, however, I am not
sure if it should
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -257,7 +258,8 @@ public Class<? extends AbstractSerDe> getSerDeClass() {
public HiveMetaHook getMetaHook() {
// Make sure to always return a new instance here, as HiveIcebergMetaHook
might hold state relevant for the
// operation.
- return new HiveIcebergMetaHook(conf);
+ return StringUtils.isEmpty(MetaStoreUtils.getCatalogType(conf)) ?
Review Comment:
ATM hadoop catalog uses HiveIcebergMetaHook as well, however, I am not sure
if it should
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
