deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2306983060
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -257,7 +258,8 @@ public Class<? extends AbstractSerDe> getSerDeClass() {
public HiveMetaHook getMetaHook() {
// Make sure to always return a new instance here, as HiveIcebergMetaHook
might hold state relevant for the
// operation.
- return new HiveIcebergMetaHook(conf);
+ return StringUtils.isEmpty(MetastoreUtil.getCatalogType(conf)) ?
Review Comment:
we should check this.
what hook would be used in case of hadoop catalog? see
hadoop_catalog_create_table.q
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -257,7 +258,8 @@ public Class<? extends AbstractSerDe> getSerDeClass() {
public HiveMetaHook getMetaHook() {
// Make sure to always return a new instance here, as HiveIcebergMetaHook
might hold state relevant for the
// operation.
- return new HiveIcebergMetaHook(conf);
+ return StringUtils.isEmpty(MetastoreUtil.getCatalogType(conf)) ?
Review Comment:
we should check this. what hook would be used in case of hadoop catalog? see
hadoop_catalog_create_table.q
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -257,7 +258,8 @@ public Class<? extends AbstractSerDe> getSerDeClass() {
public HiveMetaHook getMetaHook() {
// Make sure to always return a new instance here, as HiveIcebergMetaHook
might hold state relevant for the
// operation.
- return new HiveIcebergMetaHook(conf);
+ return StringUtils.isEmpty(MetastoreUtil.getCatalogType(conf)) ?
Review Comment:
we should check this. what hook would be used in case of hadoop catalog?
please try `hadoop_catalog_create_table.q`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
