deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2300348755


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -1135,6 +1138,20 @@ public static String getDefaultCatalog(Configuration 
conf) {
     return catName;
   }
 
+  public static String getCatalogName(Configuration conf) {
+    return Optional.ofNullable(conf.get(ICEBERG_CATALOG))

Review Comment:
   that is an HMS common class. I am not sure it's a good idea to use iceberg 
configs here
   how would it work if we have combination of Hive managed and Iceberg tables 
with custom catalog?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to