abstractdog commented on PR #6054: URL: https://github.com/apache/hive/pull/6054#issuecomment-3247989766
> 1. **The unit test failures in this PR are relevant.** The reason for this is that Pig version 0.16.0 uses jline 1.x. The jline dependency is being excluded from Pig due to an enforcer rule, which is causing failures specifically in the `hcatalog/hcatalog-pig-adapter` module. > 2. I believe the current unit test scenario in the cluster/runtime environment might also be failing because we are not shipping jline 1.x. _Assumption_: This would only work if jline 2.x, which is being shipped without this PR, is backward compatible with version 1.x. > > My recommendation for the next step is to remove the jline enforcer rule from the parent pom.xml, keeping the exclusions everywhere else except `hcatalog/hcatalog-pig-adapter`. Is that the approach acceptable? Still with this approach [2] i.e. pig working in cluster is unknown. > > [possible_follow_up.patch](https://github.com/user-attachments/files/22110301/possible_follow_up.patch) > > CC @abstractdog it is what it is, thanks @Aggarwal-Raghav for checking, but before proceeding with this, can you please check if there is an include/exclude possibility in bannedDependencies to allow old jline transitively through pig only, does it make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
