Aggarwal-Raghav commented on PR #6054: URL: https://github.com/apache/hive/pull/6054#issuecomment-3248640388
> can you please check if there is an include/exclude possibility in bannedDependencies to allow old jline transitively through pig only, does it make sense? we can use `include` tag but there are 2 ways: **1.** Do it on parent pom level: [include-tag.patch](https://github.com/user-attachments/files/22115645/include-tag.patch) - Benefit: Single place enforcer is defined. So, easy to maintain. - Drawback: For all the module jline 1.0 is enabled. But it won't be shipped in packaging. As we have excluded it from all problematic places flagged by enforcer plugin so it shouldn't be a problem. **2.** Do it on hcatalog/hcatalog-pig-adapter/pom.xml level: [include-tag-child-pom.patch](https://github.com/user-attachments/files/22115654/include-tag-child-pom.patch) - Benefit: Only for hcatalog/hcatalog-pig-adapter jline 1.0 is enabled, rest all modules are not impacted. - Drawback: Copy of enforcer plugin needs to be defined and maintainability of enforcer plugin for new bannedDependencies can be missed for this child pom. @abstractdog , please let me know which is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
