ayushtkn commented on code in PR #6074:
URL: https://github.com/apache/hive/pull/6074#discussion_r2358128423
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -310,7 +310,8 @@ private void
doPreAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
preAlterTableProperties = new PreAlterTableProperties();
preAlterTableProperties.tableLocation = sd.getLocation();
preAlterTableProperties.format = sd.getInputFormat();
- preAlterTableProperties.schema = schema(catalogProperties, hmsTable,
Collections.emptySet());
+ preAlterTableProperties.schema =
+ schema(catalogProperties, hmsTable, Collections.emptySet(),
Collections.emptyMap());
Review Comment:
As of now we don't support this in ALTER, so passing emptyMap. I double
checked ALTER doesn't override or remove any already set values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
