deniskuzZ commented on code in PR #6074: URL: https://github.com/apache/hive/pull/6074#discussion_r2358495160
########## ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java: ########## @@ -866,7 +865,7 @@ public static List<FieldSchema> getColumns( ASTNode ast, boolean lowerCase, TokenRewriteStream tokenRewriteStream, List<SQLPrimaryKey> primaryKeys, List<SQLForeignKey> foreignKeys, List<SQLUniqueConstraint> uniqueConstraints, List<SQLNotNullConstraint> notNullConstraints, - List<SQLDefaultConstraint> defaultConstraints, List<SQLCheckConstraint> checkConstraints, + List<ConstraintsUtils.ConstraintInfo> defaultConstraintInfo, List<SQLCheckConstraint> checkConstraints, Review Comment: minor: i think we can keep the naming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org