deniskuzZ commented on code in PR #6074:
URL: https://github.com/apache/hive/pull/6074#discussion_r2360269807
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -329,4 +336,85 @@ public static String convertToTypeString(Type type) {
throw new UnsupportedOperationException(type + " is not supported");
}
}
+
+ public static void setDefault(List<Types.NestedField> fields, Record record,
Set<String> missingColumns) {
+ for (Types.NestedField field : fields) {
Review Comment:
idea was to pre-filter just once not for every row. setDefaultValues should
get already pre-filtered fields
(https://github.com/apache/hive/pull/6074#discussion_r2358552106)
````
setDefaultValues(Record record, List<Types.NestedField> fields)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
