deniskuzZ commented on code in PR #6074:
URL: https://github.com/apache/hive/pull/6074#discussion_r2358517684
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -5064,6 +5070,7 @@ private RowResolver getColForInsertStmtSpec(Map<String,
ExprNodeDesc> targetCol2
}
colListPos++;
}
+ SessionStateUtil.addResource(conf, MISSING_COLUMNS, missingColumns);
Review Comment:
not sure it's a best place to populate missing columns. this is a getter
with hidden side functionality. i might be wrong. is it called just one during
the compilation?
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -5064,6 +5070,7 @@ private RowResolver getColForInsertStmtSpec(Map<String,
ExprNodeDesc> targetCol2
}
colListPos++;
}
+ SessionStateUtil.addResource(conf, MISSING_COLUMNS, missingColumns);
Review Comment:
not sure it's a best place to populate missing columns. this is a getter
with hidden side functionality. i might be wrong. is it called just once
during the compilation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
